Skip to content
  • Categories
  • Recent
  • Popular
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse

NodeBB-ActivityPub Bridge Test Instance

  1. Home
  2. Categories
  3. General Discussion
  4. AP Test (community.nodebb.org)
  5. Re: WP Multilingual plugin + ActivityPub bug

Re: WP Multilingual plugin + ActivityPub bug

Scheduled Pinned Locked Moved AP Test (community.nodebb.org)
8 Posts 2 Posters 14 Views
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • altcode@community.nodebb.orgA This user is from outside of this forum
    altcode@community.nodebb.orgA This user is from outside of this forum
    altcode@community.nodebb.org
    wrote on last edited by
    #1

    Actually, I think I know what's going on with the Vivaldi blog group actor - it's not necessarily NodeBB's fault.

    Inspecting the AP objects coming from vivaldi.com/blog, all the English-written blog posts have their as:audience field set to https://vivaldi.com/?author=0.

    Meanwhile, every other blog post that is written in a different language instead have it set to https://vivaldi.com//?author=0, so for Japanese blog posts, for example, it is https://vivaldi.com/ja/?author=0.

    And all these URLs link to different group actors, but all of them have the same value on the preferredUsername and webfinger properties: blog, and blog@vivaldi.com.


    EDIT: Actually this also appears to be all actor objects coming from vivaldi.com/blog. E.g. if you start typing [@ruari@vivaldi.com](https://community.nodebb.org/user/ruari%40vivaldi.com) or search for it, you can see it be suggested twice too.

    So my guess is that there are two person actors that NodeBB knows of that are claiming to be ruari@vivaldi.com: https://vivaldi.com/?author=46 and https://vivaldi.com/ja/?author=46.

    This is probably a bug with the WPML+ActivityPub plugin combination they have going on.


    Screenshots

    Screenshot 2025-04-02 at 23.35.28.png
    Screenshot 2025-04-02 at 23.40.47.png

    Link Preview Image
    julian@community.nodebb.orgJ 2 Replies Last reply
    0
    • altcode@community.nodebb.orgA altcode@community.nodebb.org

      Actually, I think I know what's going on with the Vivaldi blog group actor - it's not necessarily NodeBB's fault.

      Inspecting the AP objects coming from vivaldi.com/blog, all the English-written blog posts have their as:audience field set to https://vivaldi.com/?author=0.

      Meanwhile, every other blog post that is written in a different language instead have it set to https://vivaldi.com//?author=0, so for Japanese blog posts, for example, it is https://vivaldi.com/ja/?author=0.

      And all these URLs link to different group actors, but all of them have the same value on the preferredUsername and webfinger properties: blog, and blog@vivaldi.com.


      EDIT: Actually this also appears to be all actor objects coming from vivaldi.com/blog. E.g. if you start typing [@ruari@vivaldi.com](https://community.nodebb.org/user/ruari%40vivaldi.com) or search for it, you can see it be suggested twice too.

      So my guess is that there are two person actors that NodeBB knows of that are claiming to be ruari@vivaldi.com: https://vivaldi.com/?author=46 and https://vivaldi.com/ja/?author=46.

      This is probably a bug with the WPML+ActivityPub plugin combination they have going on.


      Screenshots

      Screenshot 2025-04-02 at 23.35.28.png
      Screenshot 2025-04-02 at 23.40.47.png

      Link Preview Image
      julian@community.nodebb.orgJ This user is from outside of this forum
      julian@community.nodebb.orgJ This user is from outside of this forum
      julian@community.nodebb.org
      wrote on last edited by
      #2

      @AltCode okay! Thanks for reporting, it sounds like there are two issues going on:

      1. Categories losing their handle-to-id association
        • Frustratingly, this read very similarly to #13283, and both remote users and categories share similar logic. I have so far not been able to reproduce it at all on local development.
      2. Separate users (different IDs) sharing the same preferredUsername.
        • This is an interesting one, and I am not entirely sure where the fault lies. I wonder how other software handles it?
      1 Reply Last reply
      0
      • altcode@community.nodebb.orgA altcode@community.nodebb.org

        Actually, I think I know what's going on with the Vivaldi blog group actor - it's not necessarily NodeBB's fault.

        Inspecting the AP objects coming from vivaldi.com/blog, all the English-written blog posts have their as:audience field set to https://vivaldi.com/?author=0.

        Meanwhile, every other blog post that is written in a different language instead have it set to https://vivaldi.com//?author=0, so for Japanese blog posts, for example, it is https://vivaldi.com/ja/?author=0.

        And all these URLs link to different group actors, but all of them have the same value on the preferredUsername and webfinger properties: blog, and blog@vivaldi.com.


        EDIT: Actually this also appears to be all actor objects coming from vivaldi.com/blog. E.g. if you start typing [@ruari@vivaldi.com](https://community.nodebb.org/user/ruari%40vivaldi.com) or search for it, you can see it be suggested twice too.

        So my guess is that there are two person actors that NodeBB knows of that are claiming to be ruari@vivaldi.com: https://vivaldi.com/?author=46 and https://vivaldi.com/ja/?author=46.

        This is probably a bug with the WPML+ActivityPub plugin combination they have going on.


        Screenshots

        Screenshot 2025-04-02 at 23.35.28.png
        Screenshot 2025-04-02 at 23.40.47.png

        Link Preview Image
        julian@community.nodebb.orgJ This user is from outside of this forum
        julian@community.nodebb.orgJ This user is from outside of this forum
        julian@community.nodebb.org
        wrote on last edited by
        #3

        @AltCode I forked this out to a new topic. I think it's time to loop @pfefferle@mastodon.social into the conversation (at the very least so this could be potentially escalated).

        Mattias, it seems that when the WPML and ActivityPub plugins are enabled together, notes federated out by the blog user in another language have different ids but the same preferredUsername.

        e.g. ruari@vivaldi.com: https://vivaldi.com/?author=46 and https://vivaldi.com/ja/?author=46

        NodeBB interprets this as two different users. Curiously, Mastodon does not, the second ID explicitly does not resolve.

        So there can be two solutions here:

        1. The underlying issue can be fixed by WordPress, the solution of which is out of scope (for me at least)
        2. NodeBB can adopt whatever mechanism Mastodon is using... which is most likely that Mastodon does a two-way when asserting an ID, and ensures that the webfinger resource points to the ID.
        1 Reply Last reply
        0
        • julian@community.nodebb.orgJ This user is from outside of this forum
          julian@community.nodebb.orgJ This user is from outside of this forum
          julian@community.nodebb.org
          wrote on last edited by
          #4

          The remaining questions here are:

          • whether preferredUsername is meant to be unique to the instance (in which case having multiple ids point to an identical preferredUsername would be a violation), and
          • what exactly AP software should do when it encounters this situation... store a list of "known alias" IDs? There are potential security issues to doing so.
          1 Reply Last reply
          0
          • altcode@community.nodebb.orgA This user is from outside of this forum
            altcode@community.nodebb.orgA This user is from outside of this forum
            altcode@community.nodebb.org
            wrote last edited by
            #5

            This is getting out of hand! Now, there are six of them!
            Screenshot 2025-04-22 at 11.27.24.png

            Link Preview Image
            1 Reply Last reply
            0
            • julian@community.nodebb.orgJ This user is from outside of this forum
              julian@community.nodebb.orgJ This user is from outside of this forum
              julian@community.nodebb.org
              wrote last edited by
              #6

              @AltCode This should be fixed in the upcoming v4.3.0.

              Link Preview Image
              Actor assertion should not proceed if passed-in ID does not pass a webfinger query · Issue #13352 · NodeBB/NodeBB

              I think NodeBB checks that the ID exists, and then proceeds with a full actor assert/update if it doesn't find it. Which leads to weird stuff as discovered by @altcode@community.nodebb.org where: One user with id: https://vivaldi.com/?au...

              favicon

              GitHub (github.com)

              It won't proactively remove the duplicates, but they'll be pruned out within ~7 days.

              1 Reply Last reply
              1
              0
              • System shared this topic
              • julian@community.nodebb.orgJ This user is from outside of this forum
                julian@community.nodebb.orgJ This user is from outside of this forum
                julian@community.nodebb.org
                wrote last edited by
                #7

                Bit of a thought experiment here as to how to handle these duplicate accounts.

                (tl;dr two federated accounts with different IDs report the same webfinger handle, what do?)

                Let's say @ruario@social.vivaldi.net posts an English article under his account (and then is federated), and posts a translated Japanese one that is also federated, but under the Japanese ID.

                What should NodeBB do when encountering the latter? Currently, it will try to assert the actor, fail the webfinger backreference check, and probably drop the post. Not so good.

                One could adjust the actor to the former (canonical ID), but that's not technically right either.

                That also opens up potential account impersonation possibilities, so that is something that would need addressing as well.

                1 Reply Last reply
                1
                0
                • julian@community.nodebb.orgJ This user is from outside of this forum
                  julian@community.nodebb.orgJ This user is from outside of this forum
                  julian@community.nodebb.org
                  wrote last edited by
                  #8

                  @pfefferle@mastodon.social just wanted to poke you about this issue again.

                  The latest updates to NodeBB now do a webfinger backcheck to ensure that the actor has a valid webfinger entry for their purported handle. If it does not, then the user is not properly created. Mastodon also does this. This check is probably for security as well as for preventing handle collisions.

                  The multilingual plugin in conjunction with the ActivityPub plugin creates users that share the same handle, and that causes issues with federated content.

                  For example, this article by @jonvt@vivaldi.com will load up just fine in Mastodon, but this japanese article by @akira@vivaldi.com will not, because that second article's attributedTo is https://vivaldi.com/ja/?author=176, which fails that check (the author's ID is actually https://vivaldi.com?author=176 as per the handle backcheck)

                  cc @AltCode

                  1 Reply Last reply
                  1
                  0
                  Reply
                  • Reply as topic
                  Log in to reply
                  • Oldest to Newest
                  • Newest to Oldest
                  • Most Votes


                  • Login

                  • Login or register to search.
                  Powered by NodeBB Contributors
                  • First post
                    Last post
                  0
                  • Categories
                  • Recent
                  • Popular