Re: WP Multilingual plugin + ActivityPub bug
-
Actually, I think I know what's going on with the Vivaldi blog group actor - it's not necessarily NodeBB's fault.
Inspecting the AP objects coming from vivaldi.com/blog, all the English-written blog posts have their
as:audiencefield set tohttps://vivaldi.com/?author=0.Meanwhile, every other blog post that is written in a different language instead have it set to
https://vivaldi.com//?author=0, so for Japanese blog posts, for example, it ishttps://vivaldi.com/ja/?author=0.And all these URLs link to different group actors, but all of them have the same value on the
preferredUsernameandwebfingerproperties:blog, andblog@vivaldi.com.
EDIT: Actually this also appears to be all actor objects coming from vivaldi.com/blog. E.g. if you start typing
[@ruari@vivaldi.com](https://community.nodebb.org/user/ruari%40vivaldi.com)or search for it, you can see it be suggested twice too.So my guess is that there are two person actors that NodeBB knows of that are claiming to be
ruari@vivaldi.com:https://vivaldi.com/?author=46andhttps://vivaldi.com/ja/?author=46.This is probably a bug with the WPML+ActivityPub plugin combination they have going on.
Screenshots
-
Actually, I think I know what's going on with the Vivaldi blog group actor - it's not necessarily NodeBB's fault.
Inspecting the AP objects coming from vivaldi.com/blog, all the English-written blog posts have their
as:audiencefield set tohttps://vivaldi.com/?author=0.Meanwhile, every other blog post that is written in a different language instead have it set to
https://vivaldi.com//?author=0, so for Japanese blog posts, for example, it ishttps://vivaldi.com/ja/?author=0.And all these URLs link to different group actors, but all of them have the same value on the
preferredUsernameandwebfingerproperties:blog, andblog@vivaldi.com.
EDIT: Actually this also appears to be all actor objects coming from vivaldi.com/blog. E.g. if you start typing
[@ruari@vivaldi.com](https://community.nodebb.org/user/ruari%40vivaldi.com)or search for it, you can see it be suggested twice too.So my guess is that there are two person actors that NodeBB knows of that are claiming to be
ruari@vivaldi.com:https://vivaldi.com/?author=46andhttps://vivaldi.com/ja/?author=46.This is probably a bug with the WPML+ActivityPub plugin combination they have going on.
Screenshots
@AltCode okay! Thanks for reporting, it sounds like there are two issues going on:
- Categories losing their handle-to-id association
- Frustratingly, this read very similarly to #13283, and both remote users and categories share similar logic. I have so far not been able to reproduce it at all on local development.
- Separate users (different IDs) sharing the same
preferredUsername.- This is an interesting one, and I am not entirely sure where the fault lies. I wonder how other software handles it?
- Categories losing their handle-to-id association
-
Actually, I think I know what's going on with the Vivaldi blog group actor - it's not necessarily NodeBB's fault.
Inspecting the AP objects coming from vivaldi.com/blog, all the English-written blog posts have their
as:audiencefield set tohttps://vivaldi.com/?author=0.Meanwhile, every other blog post that is written in a different language instead have it set to
https://vivaldi.com//?author=0, so for Japanese blog posts, for example, it ishttps://vivaldi.com/ja/?author=0.And all these URLs link to different group actors, but all of them have the same value on the
preferredUsernameandwebfingerproperties:blog, andblog@vivaldi.com.
EDIT: Actually this also appears to be all actor objects coming from vivaldi.com/blog. E.g. if you start typing
[@ruari@vivaldi.com](https://community.nodebb.org/user/ruari%40vivaldi.com)or search for it, you can see it be suggested twice too.So my guess is that there are two person actors that NodeBB knows of that are claiming to be
ruari@vivaldi.com:https://vivaldi.com/?author=46andhttps://vivaldi.com/ja/?author=46.This is probably a bug with the WPML+ActivityPub plugin combination they have going on.
Screenshots
@AltCode I forked this out to a new topic. I think it's time to loop @pfefferle@mastodon.social into the conversation (at the very least so this could be potentially escalated).
Mattias, it seems that when the WPML and ActivityPub plugins are enabled together, notes federated out by the blog user in another language have different
ids but the samepreferredUsername.e.g.
ruari@vivaldi.com: https://vivaldi.com/?author=46andhttps://vivaldi.com/ja/?author=46NodeBB interprets this as two different users. Curiously, Mastodon does not, the second ID explicitly does not resolve.
So there can be two solutions here:
- The underlying issue can be fixed by WordPress, the solution of which is out of scope (for me at least)
- NodeBB can adopt whatever mechanism Mastodon is using... which is most likely that Mastodon does a two-way when asserting an ID, and ensures that the webfinger resource points to the ID.
-
The remaining questions here are:
- whether
preferredUsernameis meant to be unique to the instance (in which case having multipleids point to an identicalpreferredUsernamewould be a violation), and - what exactly AP software should do when it encounters this situation... store a list of "known alias" IDs? There are potential security issues to doing so.
- whether
